Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ComputedStyle of DateTimeEditElement as font-metric-dependent #27766

Merged
merged 1 commit into from Mar 2, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 24, 2021

DateTimeEditElement::CustomStyleForLayoutObject() measures text width
with the current font, and then uses the result to set the computed
value of 'width'. Therefore, this patch marks this ComputedStyle as
font-metric-dependent, so that we can properly invalidate it when font
changes.

Bug: 1167555
Change-Id: I50cf068062bf36223de2949cea83c75a834f59d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718492
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859046}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718492 branch from e83d452 to c40e082 Feb 24, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Elements with custom style callbacks should be marked style dirty after font loading Mark ComputedStyle of DateTimeEditElement as font-metric-dependent Mar 1, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718492 branch 2 times, most recently from 95e1c3e to 9bb390e Mar 1, 2021
DateTimeEditElement::CustomStyleForLayoutObject() measures text width
with the current font, and then uses the result to set the computed
value of 'width'. Therefore, this patch marks this ComputedStyle as
font-metric-dependent, so that we can properly invalidate it when font
changes.

Bug: 1167555
Change-Id: I50cf068062bf36223de2949cea83c75a834f59d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718492
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859046}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718492 branch from 9bb390e to 3119539 Mar 2, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e30d360 into master Mar 2, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210302.51 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
update-built Community-TC (pull_request)
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2718492 branch Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants