Avoid calling AssignedSlot() on pseudo-elements #27767
Merged
Conversation
|
The review process for this patch is being conducted in the Chromium project. |
The repro from [1] causes a scrollevent to be fired on a pseudo-element inside a shadow tree, which caused a DCHECK at [2]. This CL avoids that path. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1180286#c5 Fixed: 1180286 Change-Id: I28f95d2fa5ad74da9a402a4409f972bab04aec6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718566 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#857711}
chromium-wpt-export-bot
force-pushed the
chromium-export-cl-2718566
branch
from
a70053d
to
755f432
chromium-wpt-export-bot
merged commit cb2fcc9
into
master
23 checks passed
23 checks passed
Azure Pipelines (affected tests without changes: Safari Technology Preview)
affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview)
affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests)
wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The repro from [1] causes a scrollevent to be fired on a pseudo-element
inside a shadow tree, which caused a DCHECK at [2]. This CL avoids
that path.
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1180286#c5
Fixed: 1180286
Change-Id: I28f95d2fa5ad74da9a402a4409f972bab04aec6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718566
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857711}