Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flex] Delete broken redundant flex tests #27768

Merged
merged 1 commit into from Feb 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 24, 2021

These tests rely on a CJK font such that they pass locally and pass in
chromium's waterfall, but fail on wpt.fyi. The tests rely on the
ordering of glyphs as a pass/fail condition, so using Ahem would make
the tests useless.

But we can just delete these tests because this functionality is tested
by flexbox-writing-mode-0*.html, which we recently imported from
mozilla's tree.

Change-Id: I810196cce08c05545d60744066154b1999426f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718890
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858084}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718890 branch from 4df25e9 to d2626bf Feb 24, 2021
These tests rely on a CJK font such that they pass locally and pass in
chromium's waterfall, but fail on wpt.fyi. The tests rely on the
ordering of glyphs as a pass/fail condition, so using Ahem would make
the tests useless.

But we can just delete these tests because this functionality is tested
by flexbox-writing-mode-0*.html, which we recently imported from
mozilla's tree.

Change-Id: I810196cce08c05545d60744066154b1999426f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718890
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858084}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718890 branch from d2626bf to f80fa58 Feb 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2d15ebc into master Feb 26, 2021
23 checks passed
23 checks passed
update-pr-preview
Details
Azure Pipelines Build #20210226.25 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2718890 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants