Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split VideoFrameInit into VideoFramePlaneInit. Make optional. #27769

Merged
merged 1 commit into from Feb 25, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 24, 2021

We hadn't been using the VideoFrameInit fields properly and it's
unclear how a user would know these values ahead of time, so just
make the timestamp and duration fields optional while removing all
resolution based fields.

R=chcunningham, sandersd

Bug: 1181894
Test: New tests.

Change-Id: I8ea04d2c1b4e5ef7fadb0a0287cd8adad5715862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718896
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857829}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718896 branch 2 times, most recently from 43610a5 to 696346e Feb 25, 2021
We hadn't been using the VideoFrameInit fields properly and it's
unclear how a user would know these values ahead of time, so just
make the timestamp and duration fields optional while removing all
resolution based fields.

R=chcunningham, sandersd

Bug: 1181894
Test: New tests.

Change-Id: I8ea04d2c1b4e5ef7fadb0a0287cd8adad5715862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718896
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#857829}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2718896 branch from 696346e to d5364fe Feb 25, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 244ff37 into master Feb 25, 2021
24 checks passed
24 checks passed
update-pr-preview
Details
update-pr-preview
Details
Azure Pipelines Build #20210225.77 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
download-firefox-nightly Community-TC (pull_request)
Details
lint Community-TC (pull_request)
Details
sink-task Community-TC (pull_request)
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt-chrome-dev-results Community-TC (pull_request)
Details
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
wpt-chrome-dev-stability Community-TC (pull_request)
Details
wpt-decision-task Community-TC (pull_request)
Details
wpt-firefox-nightly-results Community-TC (pull_request)
Details
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2718896 branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants