Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blink] pass callback function into profiler->StartProfiling #27771

Open
wants to merge 1 commit into
base: master
from

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 25, 2021

  • Passing in callback function for profiler->StartProfiling(),
    which is executed when max samples is reached and samples are
    being discarded
  • Server (v8) side CR:
    https://chromium-review.googlesource.com/c/v8/v8/+/2652206
  • Includes web performance tests, verifying delegate function
    invoked on 101st profiler

Change-Id: I7685c95d04fd68ef661011f4b0e7cf079e7dd2b5

Reviewed-on: https://chromium-review.googlesource.com/2649617
WPT-Export-Revision: f3417218cc38a8f03f04fd07ba5d097e91893c8d

 - Passing in callback function for profiler->StartProfiling(),
which is executed when max samples is reached and samples are
being discarded
 - Server (v8) side CR:
https://chromium-review.googlesource.com/c/v8/v8/+/2652206
 - Includes web performance tests, verifying delegate function
invoked on 101st profiler

Change-Id: I7685c95d04fd68ef661011f4b0e7cf079e7dd2b5
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants