Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webcodecs] Implement transfer semantics for VideoFrame #27772

Merged
merged 1 commit into from Apr 16, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 25, 2021

This CL adds paths for modules to implement transfer semantics:

  • ExtractTransferables() is split into the outer loop (stays in
    SerializedScriptValue) and the inner per-object processing which
    moves into V8ScriptValueSerializer. Modules can add implementations
    to V8ScriptValueSerializerForModules.

  • Transferables gains a generic TransferList map modelled after
    SerializedScriptValue::Attachment. The TransferList API includes a
    method for finalizing transfers, which is called from
    V8ScriptValueSerializer::FinalizeTransfer().

Using these APIs, transfer of VideoFrames is then implemented
straightforwardly.

Bug: 1178038
Change-Id: Iafdc02b368d09cdb04c6e48ef187a4733b14c0f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719085
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#873099}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2719085 branch 3 times, most recently from 6e44437 to 304d411 Feb 25, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2719085 branch from 304d411 to 726f235 Apr 6, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2719085 branch from 726f235 to ec05af5 Apr 14, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2719085 branch 2 times, most recently from c94332f to 41e9c38 Apr 14, 2021
This CL adds paths for modules to implement transfer semantics:

  - ExtractTransferables() is split into the outer loop (stays in
    SerializedScriptValue) and the inner per-object processing which
    moves into V8ScriptValueSerializer. Modules can add implementations
    to V8ScriptValueSerializerForModules.

  - Transferables gains a generic TransferList map modelled after
    SerializedScriptValue::Attachment. The TransferList API includes a
    method for finalizing transfers, which is called from
    V8ScriptValueSerializer::FinalizeTransfer().

Using these APIs, transfer of VideoFrames is then implemented
straightforwardly.

Bug: 1178038
Change-Id: Iafdc02b368d09cdb04c6e48ef187a4733b14c0f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2719085
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#873099}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2719085 branch from 41e9c38 to edaf1b9 Apr 15, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9dfd4b7 into master Apr 16, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210415.101 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2719085 branch Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants