Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update_html5lib_tests.py to Python 3 #27798

Merged
merged 2 commits into from Feb 26, 2021

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 26, 2021

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from annevk, domenic, foolip, jdm, jgraham and zqzhang Feb 26, 2021
@github-actions github-actions bot temporarily deployed to wpt-preview-27798 Feb 26, 2021 Inactive
zcorpan added a commit that referenced this pull request Feb 26, 2021
See html5lib/html5lib-tests#133

Spec change: whatwg/html#6399

To regenerate the tests with Python3 requires this change: #27798
@foolip
Copy link
Member

@foolip foolip commented Feb 26, 2021

Is this script exercised in CI, or does one have to run it locally to check that it still works?

@zcorpan
Copy link
Member Author

@zcorpan zcorpan commented Feb 26, 2021

It is run in CI: the update-built check runs update-build-tests.sh which runs html/tools/build.sh which is modified in this PR. I noticed it because it failed in CI when running as Python2.

@foolip
Copy link
Member

@foolip foolip commented Feb 26, 2021

OK, in that case it's pretty easy to have confidence in this, thanks Simon!

@foolip
foolip approved these changes Feb 26, 2021
@zcorpan zcorpan merged commit b0fb660 into master Feb 26, 2021
12 checks passed
12 checks passed
@github-actions
update-pr-preview
Details
@azure-pipelines
Azure Pipelines Build #20210226.28 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@zcorpan zcorpan deleted the bocoup/update_html5lib_tests_python3 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants