Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Test <svg><p> in innerHTML: Sync with html5lib-tests#133 #27799

Merged
merged 2 commits into from Mar 29, 2021

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 26, 2021

See html5lib/html5lib-tests#133

Spec change: whatwg/html#6399

To regenerate the tests with Python3 requires this change: #27798

See html5lib/html5lib-tests#133

Spec change: whatwg/html#6399

To regenerate the tests with Python3 requires this change: #27798
@zcorpan
Copy link
Member Author

@zcorpan zcorpan commented Feb 26, 2021

When html5lib/html5lib-tests#133 is merged the commit hash in html/tools/build.sh needs to be updated (and regenerate tests if there were changes).

@annevk
annevk approved these changes Feb 27, 2021
@zcorpan
Copy link
Member Author

@zcorpan zcorpan commented Mar 2, 2021

The hash is for the html5lib-python repo, not html5lib-tests, so though the tests are now merged in html5lib-tests, we also need to update the submodule in html5lib-python. I created a PR for that at html5lib/html5lib-python#531 ´

@zcorpan
Copy link
Member Author

@zcorpan zcorpan commented Mar 29, 2021

html5lib/html5lib-python#531

That is now merged.

the commit hash in html/tools/build.sh needs to be updated (and regenerate tests if there were changes).

Done.

@zcorpan zcorpan merged commit 44e250d into master Mar 29, 2021
20 checks passed
20 checks passed
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@azure-pipelines
Azure Pipelines Build #20210329.16 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@zcorpan zcorpan deleted the bocoup/sync-html5lib-svg-p-innerhtml branch Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants