Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable and move reset session to a function #27805

Merged
merged 1 commit into from Mar 4, 2021

Conversation

@k7z45
Copy link
Contributor

@k7z45 k7z45 commented Feb 26, 2021

Per https://github.com/web-platform-tests/wpt/pull/27734/files/1abbaacbe6091d252040e6a5405e4ee90b3a64f8#r583473293
move duplicate code in session and bidi_session fixture into its own function and removed unused variable is_cur_bidi

@whimboo
whimboo approved these changes Mar 1, 2021
Copy link
Contributor

@whimboo whimboo left a comment

Looks fine to me. Thanks! Just a small nit regarding naming of the argument.

webdriver/tests/support/fixtures.py Outdated Show resolved Hide resolved
@k7z45 k7z45 force-pushed the k7z45:unused branch from b84e957 to 336e695 Mar 1, 2021
@whimboo
Copy link
Contributor

@whimboo whimboo commented Mar 2, 2021

No, I'm not able to merge PRs. @jgraham would you mind doing that?

@k7z45
Copy link
Contributor Author

@k7z45 k7z45 commented Mar 4, 2021

@stephenmcgruer

Hi Stephen,

Could you or @jgraham help merging this PR, please?

@stephenmcgruer stephenmcgruer merged commit b3f0923 into web-platform-tests:master Mar 4, 2021
26 of 29 checks passed
26 of 29 checks passed
@github-actions
update-pr-preview
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@azure-pipelines
Azure Pipelines Build #20210301.40 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (infrastructure/ tests: macOS) infrastructure/ tests: macOS succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
infrastructure/ tests (Python 3) Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
resources/ tests (Python 3.8) Community-TC (pull_request)
Details
@community-tc-integration
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
tools/ integration tests (Python 3.8) Community-TC (pull_request)
Details
@community-tc-integration
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
tools/ unittests (Python 3.8) Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants