Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for adding ContextAttributes when calling getContext #28268

Merged
merged 1 commit into from Apr 9, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 28, 2021

Adding a new tag "attributes" in Canvas Template file, so that users
can do getContext('2d', attributes). I also added a test uses this
function in this cl.

Bug: 1178707

Change-Id: I020f7d83831391895b8b937e623f30f28dbcbc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2788735
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869392}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@ongweiloon777
Copy link

@ongweiloon777 ongweiloon777 commented Mar 28, 2021

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2788735 branch 2 times, most recently from 6d6a5d0 to e7b1414 Mar 29, 2021
Adding a new tag "attributes" in Canvas Template file, so that users
can do getContext('2d', attributes). I also added a test uses this
function in this cl.

Bug: 1178707

Change-Id: I020f7d83831391895b8b937e623f30f28dbcbc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2788735
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869392}
@jpchase
Copy link

@jpchase jpchase commented Apr 9, 2021

The changed tests are flaky on both Chrome Dev and Firefox nightly (this could be new or pre-existing flakes).

Chrome Dev Unstable results

Test Subtest Results Messages
/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.animated.poster.html   ERROR: 7/10, OK: 3/10  
/html/canvas/offscreen/fill-and-stroke-styles/2d.pattern.paint.repeat.basic.html   ERROR: 6/10, OK: 4/10  
/html/canvas/offscreen/fill-and-stroke-styles/2d.pattern.paint.repeat.outside.html   ERROR: 2/10, OK: 8/10  
/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html Verify that drawImage uses the size of the frame as the intinsic size of a placeholder canvas. FAIL: 6/10, PASS: 4/10 assert_equals: expected 10 but got 1

Firefox Unstable results

Test Subtest Results Messages
/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.commit.w.html   ERROR: 2/10, OK: 8/10  
@jpchase
Copy link

@jpchase jpchase commented Apr 9, 2021

Filed crbug.com/1197669. I'll force merge this PR for now.

@jpchase jpchase merged commit 62f808b into master Apr 9, 2021
20 of 23 checks passed
20 of 23 checks passed
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@azure-pipelines
Azure Pipelines Build #20210406.9 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@jpchase jpchase deleted the chromium-export-cl-2788735 branch Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants