Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 'current environment settings object' for Worker() URL parsing and COEP report #28313

Merged

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Mar 31, 2021

@zcorpan
Copy link
Member Author

@zcorpan zcorpan commented Mar 31, 2021

I don't think it's possible to test the difference between "current environment settings object" and "relevant environment settings object" when it's a constructor, since you can't do foo.call(otherWindow.foo) to invoke the constructor. It's possible I'm missing something though.

Copy link
Member

@domenic domenic left a comment

LGTM from a multi-globals perspective, with a potential small simplification.

It would be ideal to get @d0iasm's review as well from a worker/COEP reporting perspective.

<script>
async_test((t) => {
onload = () => {
document.getElementById('button').click();
@d0iasm
Copy link
Contributor

@d0iasm d0iasm commented Apr 7, 2021

Sorry for being late. LGTM! Thank you for adding the tests.

@zcorpan zcorpan merged commit 25dba84 into master Apr 7, 2021
20 checks passed
20 checks passed
@azure-pipelines
Azure Pipelines Build #20210407.28 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@zcorpan zcorpan deleted the bocoup/worker-coep-report-current-environment-settings branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants