Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSNumericValue.add and sub must throw TypeException when type different #28333

Merged
merged 1 commit into from Apr 7, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 1, 2021

According to the spec [1], CSSNumericValue.add must throw the exception
on types are different. CSSNumericValue.sub uses CSSMathSum
with negating, So it is samely required throw the exception.

Therefore, add ThrowTypeErrorIfValueIsNull() helper function
which receive the value and exception_state for throw TypeException
after checking the value is nullptr.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-add

Bug: 1193923
Change-Id: Ic131e641d2e3251d119eca04a0ce55f194596710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798149
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869972}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2798149 branch 3 times, most recently from c5dc240 to 6f276ae Apr 2, 2021
According to the spec [1], CSSNumericValue.add must throw the exception
on types are different. CSSNumericValue.sub uses CSSMathSum
with negating, So it is samely required throw the exception.

Therefore, add ThrowTypeErrorIfValueIsNull() helper function
which receive the value and exception_state for throw TypeException
after checking the value is nullptr.

[1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-add

Bug: 1193923
Change-Id: Ic131e641d2e3251d119eca04a0ce55f194596710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2798149
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869972}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2798149 branch from 6f276ae to 9df1132 Apr 7, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cf45fd0 into master Apr 7, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210407.36 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2798149 branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants