Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1702398] Use Ahem font in WPT 'align-items-baseline-overflow-non-visible.html' to avoid fuzzy failures from clipped antialiased fringe. #28336

Merged
merged 1 commit into from Apr 7, 2021

Conversation

@moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Apr 1, 2021

In this WPT test, the testcase has an 'overflow:hidden' container, while the
reference case does not. The test fails on some platforms because the "Y"
character has some antialiased fringe that bleeds imperceptibly past the
content-box, and gets clipped in the testcase but not in the reference
case. (This behavior is entirely allowable, and it shouldn't result in a test
failure. It's also unrelated to the behavior that the baseline-alignment
behavior that the test is trying to exercise.)

This patch addresses the issue by switching to the Ahem font, which is simpler
and less likely to have antialiasing fringe that would be clipped in this way.
I'm using the 25px/1 suggested styling from the documentation at
https://web-platform-tests.org/writing-tests/ahem.html

Differential Revision: https://phabricator.services.mozilla.com/D110510

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1702398
gecko-commit: f8079fe8757e972b6ebee42dcd4c940c50042289
gecko-reviewers: emilio

… to avoid fuzzy failures from clipped antialiased fringe.

In this WPT test, the testcase has an 'overflow:hidden' container, while the
reference case does not. The test fails on some platforms because the "Y"
character has some antialiased fringe that bleeds imperceptibly past the
content-box, and gets clipped in the testcase but not in the reference
case. (This behavior is entirely allowable, and it shouldn't result in a test
failure. It's also unrelated to the behavior that the baseline-alignment
behavior that the test is trying to exercise.)

This patch addresses the issue by switching to the Ahem font, which is simpler
and less likely to have antialiasing fringe that would be clipped in this way.
I'm using the 25px/1 suggested styling from the documentation at
https://web-platform-tests.org/writing-tests/ahem.html

Differential Revision: https://phabricator.services.mozilla.com/D110510

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1702398
gecko-commit: f8079fe8757e972b6ebee42dcd4c940c50042289
gecko-reviewers: emilio
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@dholbert
Copy link
Contributor

@dholbert dholbert commented Apr 2, 2021

The wpt-firefox-nightly-results-without-changes failure (in this log) that's blocking this from merging is:

ssl.SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1108)

Looks like an infra issue of some sort. @jgraham do you know if we can retrigger that task, or what the right thing to do is here?

@jgraham jgraham closed this Apr 6, 2021
@jgraham jgraham reopened this Apr 6, 2021
@jgraham
Copy link
Contributor

@jgraham jgraham commented Apr 6, 2021

@dholbert the easiest way to retrigger is just to close and reopen the PR. I've done that now so we'll see if it works out ;)

@dholbert
Copy link
Contributor

@dholbert dholbert commented Apr 6, 2021

Thanks!

Looks like that sort-of worked -- this now shows "all checks have passed" as the status, with a "Squash and merge" button that's available to me but which I'm hesitant to press without knowing if automation is supposed to do that part for me & is just pending for some reason. :)

@moz-wptsync-bot moz-wptsync-bot merged commit 2819bea into master Apr 7, 2021
20 checks passed
20 checks passed
@azure-pipelines
Azure Pipelines Build #20210406.20 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@moz-wptsync-bot
upstream/gecko Landed on mozilla-central
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1702398 branch Apr 7, 2021
@dholbert
Copy link
Contributor

@dholbert dholbert commented Apr 7, 2021

..and the bot merged the commit 4 minutes after I posted. Hooray! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants