Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set top-level module script request for SWs to same-origin mode #28340

Merged
merged 1 commit into from Apr 9, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 1, 2021

Top-level module script request for service workers should be set to
same-origin mode. Link to the spec discussion issue can be found at
whatwg/html#6544.

Bug: 1194571
Change-Id: I8247669d23ef84fa879f743b699c6e11ac49bb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2797663
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869300}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2797663 branch 4 times, most recently from 6064c2a to 3641ba2 Apr 1, 2021
Top-level module script request for service workers should be set to
same-origin mode. Link to the spec discussion issue can be found at
whatwg/html#6544.

Bug: 1194571
Change-Id: I8247669d23ef84fa879f743b699c6e11ac49bb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2797663
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869300}
@jpchase
Copy link

@jpchase jpchase commented Apr 9, 2021

The new tests are slow on Chrome dev:

Slow tests

Test Result Longest duration (ms) Timeout (ms)
/service-workers/service-worker/update-module-request-mode.https.html OK 9132 10000

Slow tests indicate that a test ran very close to the test timeout limit and so may become TIMEOUT-flaky in the future. Consider speeding up the test or breaking it into multiple tests. For help, please tag @web-platform-tests/wpt-core-team in a comment.

@jpchase
Copy link

@jpchase jpchase commented Apr 9, 2021

Filed crbug.com/1197660. I'll force merge this PR.

@jpchase jpchase merged commit c4729bf into master Apr 9, 2021
20 of 22 checks passed
20 of 22 checks passed
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@azure-pipelines
Azure Pipelines Build #20210405.38 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@jpchase jpchase deleted the chromium-export-cl-2797663 branch Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants