Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reland]: Relax constraints on scroll snapping for snap-type both. #28341

Merged
merged 1 commit into from Apr 8, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 1, 2021

Originally landed in:
https://chromium-review.googlesource.com/c/chromium/src/+/2785142

Reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/2798148

due to an MSan failure.

Failure addressed in Patchset 2. The problem was caused by an improperly
initialized variable. Confirmed MSan failure and fix locally.

Bug: 626703
Change-Id: I6b4823ae596109d114a8e95ab3ee72db84c35f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2800233
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870491}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2800233 branch from 3c0dea4 to b738f05 Apr 1, 2021
Originally landed in:
https://chromium-review.googlesource.com/c/chromium/src/+/2785142

Reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/2798148

due to an MSan failure.

Failure addressed in Patchset 2. The problem was caused by an improperly
initialized variable.  Confirmed MSan failure and fix locally.

Bug: 626703
Change-Id: I6b4823ae596109d114a8e95ab3ee72db84c35f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2800233
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870491}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2800233 branch from b738f05 to 71359aa Apr 8, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 546f149 into master Apr 8, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210408.10 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2800233 branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants