[Gecko Bug 1702835] Min/Max size transfers should work only when inline size is not specified. #28376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fied. We have to apply min/max transferred size if inline size is auto or intrinsic size keywords. The basic principle is that sizing constraints transfer through the aspect-ratio to the other side to preserve the aspect ratio to the extent that they can without violating any sizes specified explicitly on that affected axis. Note: block-aspect-ratio-021.html tests the similar case with the non-zero content size. However we don't have the similar tests for intrinsic size keywords, so I add them in this patch as well. Differential Revision: https://phabricator.services.mozilla.com/D110725 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1702835 gecko-commit: 379285a42f124620d09d77524db5465e1591e001 gecko-reviewers: TYLin, emilio
wpt-pr-bot
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to apply min/max transferred size if inline size is auto or intrinsic
size keywords.
The basic principle is that sizing constraints transfer through the
aspect-ratio to the other side to preserve the aspect ratio to the extent
that they can without violating any sizes specified explicitly on that
affected axis.
Note: block-aspect-ratio-021.html tests the similar case with the non-zero
content size. However we don't have the similar tests for intrinsic size
keywords, so I add them in this patch as well.
Differential Revision: https://phabricator.services.mozilla.com/D110725
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1702835
gecko-commit: 379285a42f124620d09d77524db5465e1591e001
gecko-reviewers: TYLin, emilio