Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1626108] Adjust test expectations in flexbox WPT negative-overflow.html, to indicate that negative cross-axis overflow in a "wrap-reverse" flexbox should be scrollable. #28389

Merged
merged 1 commit into from Apr 7, 2021

Conversation

@moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Apr 6, 2021

This testcase wasn't accounting for the fact that "flex-wrap: wrap-reverse"
flips the direction in which overflow is reachable/scrollable, in a flex
container's cross axis (just as "flex-direction: column-reverse" does in the
main axis). The CSSWG resolved on this here:
https://lists.w3.org/Archives/Public/www-style/2014Sep/0187.html

This commit makes the test account for this, by increasing the expected
scrollHeight of the "wrap-reverse" pieces of the test (which have overflow that
should be scrollable).

Note that Chromium doesn't pass these amended subtests, because it doesn't
correctly handle scrolling with wrap-reverse; this is covered by
https://bugs.chromium.org/p/chromium/issues/detail?id=1114306 . (However, if I
modify the test to use "wrap" instead of "wrap-reverse", then Chromium does
pass these subtests. This indicates that Chromium does essentially agree on
the expected value here, aside from that bug report about making the overflow
scrollable.)

Differential Revision: https://phabricator.services.mozilla.com/D110968

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1626108
gecko-commit: 5574f84255953f4cbb1616e51fb9efa1f846c108
gecko-reviewers: TYLin

…dicate that negative cross-axis overflow in a "wrap-reverse" flexbox should be scrollable.

This testcase wasn't accounting for the fact that "flex-wrap: wrap-reverse"
flips the direction in which overflow is reachable/scrollable, in a flex
container's cross axis (just as "flex-direction: column-reverse" does in the
main axis).  The CSSWG resolved on this here:
https://lists.w3.org/Archives/Public/www-style/2014Sep/0187.html

This commit makes the test account for this, by increasing the expected
scrollHeight of the "wrap-reverse" pieces of the test (which have overflow that
should be scrollable).

Note that Chromium doesn't pass these amended subtests, because it doesn't
correctly handle scrolling with wrap-reverse; this is covered by
https://bugs.chromium.org/p/chromium/issues/detail?id=1114306 .  (However, if I
modify the test to use "wrap" instead of "wrap-reverse", then Chromium does
pass these subtests.  This indicates that Chromium does essentially agree on
the expected value here, aside from that bug report about making the overflow
scrollable.)

Differential Revision: https://phabricator.services.mozilla.com/D110968

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1626108
gecko-commit: 5574f84255953f4cbb1616e51fb9efa1f846c108
gecko-reviewers: TYLin
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit 1836846 into master Apr 7, 2021
20 checks passed
20 checks passed
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@azure-pipelines
Azure Pipelines Build #20210406.53 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@moz-wptsync-bot
upstream/gecko Landed on mozilla-central
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1626108 branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants