Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Expand bounds of mask layer by 1 pixel" #28391

Merged
merged 1 commit into from Apr 7, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 7, 2021

This reverts commit c0d54d1aa9b348261e4e3b550ad02e746229b9ac.

Reason for revert: The CL caused crbug.com/1196148.

Original change's description:

Expand bounds of mask layer by 1 pixel

This is similar to crrev.com/c/2786129 which is for synthesized clip
mask layer, to ensure the mask fully covers the masked contents
regardless of computation errors in later stages.

To make that work, we also need to decomposite the MaskClip on the mask
layer, otherwise the expanded pixels would be clipped off and would
have no effect.

Bug: 1171601
Change-Id: I3198f228de1a0aa8baf2b8ed3c670ceabdeb57a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787695
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869079}

Bug: 1171601, 1196148
Change-Id: I31d960ddee5e2b7bb34cbfd676e8e29718324fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809522
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#869821}

This reverts commit c0d54d1aa9b348261e4e3b550ad02e746229b9ac.

Reason for revert: The CL caused crbug.com/1196148.

Original change's description:
> Expand bounds of mask layer by 1 pixel
>
> This is similar to crrev.com/c/2786129 which is for synthesized clip
> mask layer, to ensure the mask fully covers the masked contents
> regardless of computation errors in later stages.
>
> To make that work, we also need to decomposite the MaskClip on the mask
> layer, otherwise the expanded pixels would be clipped off and would
> have no effect.
>
> Bug: 1171601
> Change-Id: I3198f228de1a0aa8baf2b8ed3c670ceabdeb57a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2787695
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#869079}

Bug: 1171601, 1196148
Change-Id: I31d960ddee5e2b7bb34cbfd676e8e29718324fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2809522
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#869821}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ba6f0d2 into master Apr 7, 2021
18 of 21 checks passed
18 of 21 checks passed
@azure-pipelines
Azure Pipelines
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs)
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes)
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-102a0a7655 branch Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants