Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call ChildrenRemoved() in base class first #28392

Merged
merged 1 commit into from Apr 7, 2021

Commits on Apr 7, 2021

  1. Call ChildrenRemoved() in base class first

    Removed style recalc root has to be updated in
    ContainerNode::ChildrenRemoved() before we can start marking style dirty
    for the object/plugin. Otherwise the style traversal root code triggers
    a DCHECK.
    
    Bug: 1195633
    Change-Id: I2e41a66ba869a23e1d3f246d3e1ba4d862709f3f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2807619
    Reviewed-by: Mason Freed <masonf@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#869908}
    Rune Lillesveen authored and chromium-wpt-export-bot committed Apr 7, 2021
    Copy the full SHA
    985ad2e View commit details
    Browse the repository at this point in the history