Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that document.open() removes initial about:blankness #28403

Merged
merged 2 commits into from Apr 14, 2021

Conversation

@domenic
Copy link
Member

@domenic domenic commented Apr 7, 2021

Follows whatwg/html#6567.

@foolip
foolip approved these changes Apr 12, 2021
Copy link
Member

@foolip foolip left a comment

Superb comments in this test!

Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@annevk
annevk approved these changes Apr 13, 2021

// Create the Window object. It will be for the initial about:blank since the load of /common/blank.html hasn't
// completed.
document.body.append(iframe);

This comment has been minimized.

@annevk

annevk Apr 13, 2021
Member

One quibble about these comments, it'll only start loading/navigating right here, right?

This comment has been minimized.

@domenic

domenic Apr 14, 2021
Author Member

Yeah, the comment on lines 10-12 applies to both lines 13 and 17.

@domenic domenic merged commit d405c38 into master Apr 14, 2021
20 checks passed
20 checks passed
@azure-pipelines
Azure Pipelines Build #20210412.12 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@domenic domenic deleted the remove-initial-about-blankness branch Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants