Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flex/tables] Stop flex from shrinking tables below their min height #28406

Merged
merged 1 commit into from Apr 8, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 8, 2021

Tables can't have height less than their intrinsic block size.
Otherwise, cells would overflow the table, which breaks a table
invariant.

FlexNG was assigning tables heights that are too short. Legacy tables
ignored FlexNG and assigned themselves a proper height, so we never
noticed this bug. TablesNG was trying to obey flex's imposed height,
which brought this FlexNG bug to light.

Now FlexNG always assigns a block size greater than or equal to the
table's intrinsic block size when it is laid out with whatever final
inline size the flexbox gives (stretched or unstretched).

There is no spec requiring this in the block direction, even though
Firefox and legacy Blink both do it, and there is a spec requirement for
the inline direction. So the tests are marked tentative.

Bug: 1181403
Change-Id: I538188d2749d0c1e0a277068c59fbb26759b1756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2810520
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870270}

Tables can't have height less than their intrinsic block size.
Otherwise, cells would overflow the table, which breaks a table
invariant.

FlexNG was assigning tables heights that are too short. Legacy tables
ignored FlexNG and assigned themselves a proper height, so we never
noticed this bug. TablesNG was trying to obey flex's imposed height,
which brought this FlexNG bug to light.

Now FlexNG always assigns a block size greater than or equal to the
table's intrinsic block size when it is laid out with whatever final
inline size the flexbox gives (stretched or unstretched).

There is no spec requiring this in the block direction, even though
Firefox and legacy Blink both do it, and there is a spec requirement for
the inline direction. So the tests are marked tentative.

Bug: 1181403
Change-Id: I538188d2749d0c1e0a277068c59fbb26759b1756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2810520
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870270}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 0c857e7 into master Apr 8, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210408.1 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-52a1d3cd9d branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants