Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid relying on vertical scrollbar placement in a couple of tests. #28425

Merged
merged 1 commit into from Apr 11, 2021

Conversation

@heycam
Copy link
Contributor

@heycam heycam commented Apr 9, 2021

These two tests can end up placing their root vertical scrollbars on different sides of the window, due to the use of different writing modes. They aren't specifically testing anything to do with scrollbars, so we turn them off.

@@ -18,6 +18,8 @@
{
height: 100%;
writing-mode: vertical-rl;
overflow: hidden; /* since test and reference would place scrollbars on

This comment has been minimized.

@dholbert

dholbert Apr 9, 2021
Contributor

Maybe s/would place/might place/, throughout this commit?

(I don't think these styles do actually place scrollbars on opposite sides in any browsers right now; I think because the root scrollport has special behavior, in Firefox at least. I suspect that's changing in WebKit in https://bugs.webkit.org/show_bug.cgi?id=224224 though.)

This comment has been minimized.

@heycam

heycam Apr 9, 2021
Author Contributor

Now I am uncertain whether I do want to change root scrollbar placement in that bug. :-) If I do, I'll merge this PR. If not, I'll abandon it.

This comment has been minimized.

@heycam

heycam Apr 9, 2021
Author Contributor

OK so I think I do want to change the placement, since we already change the placement for horizontal RTL documents.

This comment has been minimized.

@dholbert

dholbert Apr 9, 2021
Contributor

Yup, I noticed that. Makes sense. thanks!

These two tests can end up placing their root vertical scrollbars on different sides of
the window, due to the use of different writing modes.  They aren't specifically testing
anything to do with scrollbars, so we turn them off.
@heycam heycam force-pushed the heycam:vertical-scrollbar-pos branch from 05d1e66 to 145cbe9 Apr 11, 2021
@wpt-pr-bot
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot commented Apr 11, 2021

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@heycam heycam merged commit 6be0588 into web-platform-tests:master Apr 11, 2021
16 checks passed
16 checks passed
@azure-pipelines
Azure Pipelines Build #20210411.2 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants