Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop async scripts running between parser pumps #28485

Merged
merged 1 commit into from May 4, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 14, 2021

Some pages assume that async scripts don't run in between sync
<script> tags. They probably shouldn't, but this fixes the
behaviour.

Bug: 1197376, 901056
Change-Id: Icd1779f164db77794e25dbcd6e3e92582a55d7a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826128
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#878839}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title force defer async scripts with foreground parser fix: force defer async scripts with foreground parser Apr 14, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2826128 branch 3 times, most recently from b466f33 to d27431f Apr 16, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title fix: force defer async scripts with foreground parser fix: stop async scripts running between parser pumps Apr 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2826128 branch 3 times, most recently from 54d35ed to 70364b7 Apr 29, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2826128 branch from 70364b7 to 6191bb9 May 4, 2021
Some pages assume that async scripts don't run in between sync
<script> tags. They probably shouldn't, but this fixes the
behaviour.

Bug: 1197376, 901056
Change-Id: Icd1779f164db77794e25dbcd6e3e92582a55d7a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826128
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#878839}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2826128 branch from 6191bb9 to a09f40d May 4, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit a26300b into master May 4, 2021
23 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2826128 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants