Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change slot.assign() from sequence to variadic #28699

Merged
merged 1 commit into from May 5, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 26, 2021

This spec change wasn't noticed when [1] was landed. This CL aligns
the implementation and WPTs with the spec IDL file [2]. As with [1],
the use counter [3] is very low, so there should not be compat
concerns with this change.

I have requested a re-review of the I2S, at [4]. I will wait to ship
this until I receive 3 more LGTMs there.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2824763
[2] https://html.spec.whatwg.org/#htmlslotelement
[3] https://chromestatus.com/metrics/feature/timeline/popularity/3442
[4] https://groups.google.com/a/chromium.org/g/blink-dev/c/6U78F3KWJ78/m/CExRJ9KlBQAJ

Fixed: 1202591
Bug: 1196842
Change-Id: If0e21d2f3329b9903a9ffeb0df4a80143f6e1581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2851439
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879190}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2851439 branch 3 times, most recently from 2b8ba54 to a186673 Apr 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2851439 branch 2 times, most recently from 8add20d to 053a177 May 4, 2021
This spec change wasn't noticed when [1] was landed. This CL aligns
the implementation and WPTs with the spec IDL file [2]. As with [1],
the use counter [3] is *very* low, so there should not be compat
concerns with this change.

I have requested a re-review of the I2S, at [4]. I will wait to ship
this until I receive 3 more LGTMs there.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2824763
[2] https://html.spec.whatwg.org/#htmlslotelement
[3] https://chromestatus.com/metrics/feature/timeline/popularity/3442
[4] https://groups.google.com/a/chromium.org/g/blink-dev/c/6U78F3KWJ78/m/CExRJ9KlBQAJ

Fixed: 1202591
Bug: 1196842
Change-Id: If0e21d2f3329b9903a9ffeb0df4a80143f6e1581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2851439
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879190}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2851439 branch from 053a177 to e38e1b6 May 5, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit babc2a1 into master May 5, 2021
20 checks passed
20 checks passed
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@azure-pipelines
Azure Pipelines Build #20210505.9 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2851439 branch May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants