Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1708702] Add to radio group after handling type change #28786

Merged
merged 1 commit into from May 4, 2021

Conversation

@moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented May 3, 2021

The previous assumption was that mType would be updated before AfterSetAttr(), but that assumption is invalidated by bug 1347640. This patch moves the radio group addition part to the position after HandleTypeChange() is called.

Differential Revision: https://phabricator.services.mozilla.com/D114038

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1708702
gecko-commit: 0801f8d2da14752a98507a8139922525bf791402
gecko-reviewers: edgar

The previous assumption was that mType would be updated before AfterSetAttr(), but that assumption is invalidated by bug 1347640. This patch moves the radio group addition part to the position after HandleTypeChange() is called.

Differential Revision: https://phabricator.services.mozilla.com/D114038

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1708702
gecko-commit: 0801f8d2da14752a98507a8139922525bf791402
gecko-reviewers: edgar
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit d4dc23f into master May 4, 2021
21 checks passed
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1708702 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants