Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tools/wpt/ tests that require Chrome Dev #28790

Merged
merged 1 commit into from May 3, 2021

Conversation

@foolip
Copy link
Member

@foolip foolip commented May 3, 2021

This skips all tests that pass --channel dev, since even if they don't
fail they could be passing for the wrong reason.

Don't use xfail, because these tests could pass on Windows with Chrome
Dev installled, it's just that it's not installed in our CI setup.

Part of #28745.

This skips all tests that pass --channel dev, since even if they don't
fail they could be passing for the wrong reason.

Don't use xfail, because these tests could pass on Windows with Chrome
Dev installled, it's just that it's not installed in our CI setup.

Part of #28745.
jgraham
jgraham approved these changes May 3, 2021
@jgraham jgraham merged commit 377f1b2 into master May 3, 2021
41 checks passed
@jgraham jgraham deleted the foolip/win32-skip-chrome-dev branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants