Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expect newline normalizations when constructing the entry list #28798

Merged
merged 3 commits into from May 20, 2021
Merged

Don't expect newline normalizations when constructing the entry list #28798

merged 3 commits into from May 20, 2021

Conversation

@andreubotella
Copy link
Member

@andreubotella andreubotella commented May 3, 2021

This tests the spec changes in whatwg/html#6624, as well as the <textarea> cases to be covered in a follow-up spec PR (#6697).

This tests the spec changes in whatwg/html#6624, as well as the textarea
cases to be covered in a follow-up spec PR.
Copy link
Member

@annevk annevk left a comment

Thanks for writing these!

The textarea test should have tentative in the filename (or be aligned with the existing specification for now) as I don't think it's clear what decision we'll make there.

@andreubotella
Copy link
Member Author

@andreubotella andreubotella commented May 19, 2021

Since the decision to normalize textareas to LF has now been taken, and the corresponding PR is now open at whatwg/html#6697, it seems like this can now be merged with no further changes.

annevk
annevk approved these changes May 20, 2021
@annevk annevk merged commit a35aa40 into web-platform-tests:master May 20, 2021
27 checks passed
annevk added a commit to whatwg/html that referenced this issue May 20, 2021
As of #6287 newlines are normalized when form data is serialized. This removes the (mostly redundant) normalization in constructing the entry list.

Tests: web-platform-tests/wpt#28798.

Follow-up: #6697.

Fixes #6469.
@andreubotella andreubotella deleted the dont-normalize-entry-list branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants