Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test document.write() during readystatechange to interactive #28799

Merged
merged 1 commit into from May 4, 2021

Conversation

@domenic
Copy link
Member

@domenic domenic commented May 3, 2021

Follows whatwg/html#6613.

annevk
annevk approved these changes May 4, 2021
domenic added a commit to whatwg/html that referenced this issue May 4, 2021
* Explicitly call out to "update the current document readiness" when we want the side effects to happen.

* Do not fire readystatechange if the value does not actually change.

* Update the insertion point before firing readystatechange.

* Make parser-less documents not be a special case, because most of them end up calling "stop parsing" before any script runs anyway.

* Move everything related to current document readiness into the "Reporting document loading status" section.

Most of these are not observable, because script cannot run during the times when these values are changing. The exception is that we now update the insertion point before firing readystatechange, whereas the previous not-very-precise phrasing seemed to imply that you'd update the insertion point afterward.

The new order matches implementations, as seen from the test at web-platform-tests/wpt#28799.
@domenic domenic merged commit 858abd0 into master May 4, 2021
27 checks passed
@domenic domenic deleted the current-document-readiness branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants