Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement colorMatrix filters for CanvasFilter objects #28802

Merged
merged 1 commit into from May 6, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 3, 2021

The existing SVG interface has been copied exactly, even when it doesn't
make a ton of sense, for example:
ctx.filter = new CanvasFilter({colorMatrix: {type: "saturate", values: 0.5}});
Uses the key "values" instead of "value", even though it's only a single
number.

Bug: 1169216
Change-Id: I6242f1909645ee4a2f7a6258b6563b44f3eb76eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2855935
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879788}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2855935 branch 3 times, most recently from 34bbe91 to fda341b May 6, 2021
The existing SVG interface has been copied exactly, even when it doesn't
make a ton of sense, for example:
  ctx.filter = new CanvasFilter({colorMatrix: {type: "saturate", values: 0.5}});
Uses the key "values" instead of "value", even though it's only a single
number.

Bug: 1169216
Change-Id: I6242f1909645ee4a2f7a6258b6563b44f3eb76eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2855935
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879788}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2855935 branch from fda341b to fc59469 May 6, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c4c81d2 into master May 6, 2021
23 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2855935 branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants