Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values-3] Improve attr-px-invalid-cast.html and attr-px-invalid-fallback.html tests #28816

Merged
merged 2 commits into from May 5, 2021

Conversation

@TalbotG
Copy link
Contributor

@TalbotG TalbotG commented May 4, 2021

attr-px-invalid-cast.html
attr-px-invalid-fallback.html

I must first convert the line-starting tabs with 2 blank spaces so that the lint tool does not report this and so that the review of the tests can be easier.

The corrections have been explained in Issue 28765 and in Issue 28794 .

@TalbotG TalbotG requested review from frivoal, FremyCompany and fantasai May 4, 2021
@TalbotG TalbotG self-assigned this May 4, 2021
@wpt-pr-bot wpt-pr-bot requested review from dbaron, plinss and tabatkins May 4, 2021
@TalbotG TalbotG removed request for dbaron, tabatkins and plinss May 4, 2021
@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented May 4, 2021

There are still a few small issues (extraneous declarations, browsers with no support for attr() will pass attr-px-invalid-fallback.html) with the 2 tests but, now, the 2 tests have been corrected and this is what is important here.

Copy link
Contributor

@FremyCompany FremyCompany left a comment

Looks good to me. These tests are somewhat tricky to review, you really gotta look at the spec to confirm all the details 😆

One thing that could be done is that my email address could optionally be updated to my current one (francois.remy.dev (arobase) outlook.com), but given this is only a set of two tests that might not be the appropriate commit to do that.

Thanks for noticing the asset help mismatch.

@TalbotG TalbotG merged commit 5bba0ea into web-platform-tests:master May 5, 2021
19 checks passed
19 checks passed
@azure-pipelines
Azure Pipelines Build #20210504.35 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@TalbotG
Copy link
Contributor Author

@TalbotG TalbotG commented May 5, 2021

François,

The 8.2. Attribute References: attr() section could be improved with, say, 2 or 3 additional examples. I have created Issue 6268 on this.
Your 2 tests could be furthermore improved.
Several of your tests use 1 starting-line tab and the Lint tool will report the INDENT TABS error:
"INDENT TABS
Test-file line starts with one or more tab characters
To fix:
use spaces to replace any tab characters at beginning of lines
"
http://web-platform-tests.org/writing-tests/lint-tool.html#fixing-lint-errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants