Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit synthetic mask for non-2d-axis aligned clip for backdrop effects #28823

Merged
merged 1 commit into from May 4, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 4, 2021

The bug case is that a clip applies to a composited backdrop effect
(backdrop-filter or mix-blend-mode), the clipping element doesn't
create an isolation group for the backdrop effect, and the clip is
not 2d-axis aligned to the containing isolation group. In the case
we need to apply the clip as a synthetic mask. (For normal non-2d-axis
aligned clip we decomposite the clip to emit a paint operation in the
composited layer for the clip.)

Bug: 1202369
Change-Id: I54112516e1603f65ae99d6a2167c8dc1ee6107da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872248
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879093}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

The bug case is that a clip applies to a composited backdrop effect
(backdrop-filter or mix-blend-mode), the clipping element doesn't
create an isolation group for the backdrop effect, and the clip is
not 2d-axis aligned to the containing isolation group. In the case
we need to apply the clip as a synthetic mask. (For normal non-2d-axis
aligned clip we decomposite the clip to emit a paint operation in the
composited layer for the clip.)

Bug: 1202369
Change-Id: I54112516e1603f65ae99d6a2167c8dc1ee6107da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872248
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879093}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2872248 branch from f9b2050 to ff73306 May 4, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 891d0e1 into master May 4, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2872248 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants