Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <popup> focus, autofocus, delegatesfocus #28827

Merged
merged 2 commits into from May 8, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 4, 2021

This CL implements most of the focus behavior for <popup. This includes
the default focus behavior, plus the implementation of the autofocus
and delegatesfocus attributes. See [1] for more context. A WPT is
added here that exercised all new functionality.

[1] https://open-ui.org/components/popup.research.explainer

Bug: 1168738
Change-Id: I6ec607c7dc250c8edb0d8bd4245e0f21303599a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2869490
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#879576}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2869490 branch from 61feb5a to 41356a7 May 5, 2021
This CL implements most of the focus behavior for <popup. This includes
the default focus behavior, plus the implementation of the autofocus
and delegatesfocus attributes. See [1] for more context. A WPT is
added here that exercised all new functionality.

[1] https://open-ui.org/components/popup.research.explainer

Bug: 1168738
Change-Id: I6ec607c7dc250c8edb0d8bd4245e0f21303599a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2869490
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#879576}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c7701fb into master May 8, 2021
20 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2869490 branch May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants