Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OffscreenCanvas tests to respect [EnforceRange] idl annotation #28836

Merged

Conversation

@Cwiiis
Copy link
Contributor

@Cwiiis Cwiiis commented May 5, 2021

At some point, getImageData and OffscreenCanvas width/height properties were updated to use [EnforceRange] (I guess this happened at the same time as the same changes in canvas) - this updates the tests to respect this. There are already range-related tests for getImageData, so 2d.imageData.get.tiny can just be removed, size.attributes.idl I've updated to check that the exceptions are thrown and that setting out of range values has no effect.

@annevk
annevk approved these changes May 5, 2021
Copy link
Member

@annevk annevk left a comment

Did you check that this matches Chrome?

@Cwiiis
Copy link
Contributor Author

@Cwiiis Cwiiis commented May 5, 2021

Did you check that this matches Chrome?

At least with the version of Chrome I have on my desktop (90.0.4430.93), this will now fail, but this matches the spec (and works in WebKit).

@Cwiiis
Copy link
Contributor Author

@Cwiiis Cwiiis commented May 5, 2021

Did you check that this matches Chrome?

At least with the version of Chrome I have on my desktop (90.0.4430.93), this will now fail, but this matches the spec (and works in WebKit).

I just checked Chrome experimental results, and these are indeed failing there and should pass after these changes.

@Cwiiis Cwiiis merged commit bbe3c01 into web-platform-tests:master May 5, 2021
23 checks passed
23 checks passed
@azure-pipelines
Azure Pipelines Build #20210505.35 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
infrastructure/ tests Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
resources/ tests (Python 3.9) Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants