Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate pointerId, pointerType for contextmenu event #28844

Merged
merged 1 commit into from May 10, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

For contextmenu as a pointer event pointerId and pointerType
were not populated.

In this CL we are populating pointerId/pointerType for contextmenu
coming from touch and mouse.
For touch we use a similar approach to crrev.com/c/2800231
for populating pointerId,pointerType for clicks generated in
GestureManager::HandleGestureTap.
The main change will be in EventHandler::SendContextMenuEvent
where we'll be passing id and pointer type to the call to
MouseEventManager::DispatchMouseEvent. This in turn will
populate pointerId and pointerType correctly when the contextmenu
PointerEvent is created.

Bug: 1150442,1150441
TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html
Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881145}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2874026 branch 5 times, most recently from 31d75ba to 0a96fdf May 6, 2021
For contextmenu as a pointer event pointerId and pointerType
were not populated.

In this CL we are populating pointerId/pointerType for contextmenu
coming from touch and mouse.
For touch we use a similar approach to crrev.com/c/2800231
for populating pointerId,pointerType for clicks generated in
GestureManager::HandleGestureTap.
The main change will be in EventHandler::SendContextMenuEvent
where we'll be passing id and pointer type to the call to
MouseEventManager::DispatchMouseEvent. This in turn will
populate pointerId and pointerType correctly when the contextmenu
PointerEvent is created.

Bug: 1150442,1150441
TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html
Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881145}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2874026 branch from 0a96fdf to f18df9d May 10, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 4e30d69 into master May 10, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210510.64 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2874026 branch May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants