Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let inherited_time be zero for new CSS animations with no timeline #28851

Merged
merged 1 commit into from May 6, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

There is currently an inconsistency between CSS animations and JS
animations: creating a JS animation with a null-timeline causes
current time to be held at zero, but the same does not happen in
the equivalent case for CSS animations. Instead, new CSS animations
without a timeline effectively have no current time.

This inconsistency is possible because of how we use InertEffect
in the first frame to "simulate" what the real Animation would have
done, and in this case that simulation is wrong.

Bug: 1074052
Change-Id: I3ef7de3eb3ea7812cd45d7dca41db59d42310a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874659
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880042}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

There is currently an inconsistency between CSS animations and JS
animations: creating a JS animation with a null-timeline causes
current time to be held at zero, but the same does not happen in
the equivalent case for CSS animations. Instead, new CSS animations
without a timeline effectively have *no* current time.

This inconsistency is possible because of how we use InertEffect
in the first frame to "simulate" what the real Animation would have
done, and in this case that simulation is wrong.

Bug: 1074052
Change-Id: I3ef7de3eb3ea7812cd45d7dca41db59d42310a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874659
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880042}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2874659 branch from 18112d2 to 6f53a3f May 6, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit debbb94 into master May 6, 2021
22 checks passed
22 checks passed
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@azure-pipelines
Azure Pipelines Build #20210506.64 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2874659 branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants