Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridNG] Fix invalidation logic for out of flow items via simplified layout #28852

Merged
merged 1 commit into from May 26, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

This CL addresses a failure where an absolutely positioned item changed
its position dynamically. Previously, a new |containing_block_rect| was
not being added nor re-computed in |SimplifiedLayoutAlgorithm| for
out of flow items that are children of the grid, thus their position was
incorrect. This change computes the new containing block by calling
existing helpers in |NGGridLayoutAlgorithm|. As a result, some methods
had to be changed and constructors overloaded in order to use what was
already computed and stored in |NGGridData|.

Bug: 1045599
Change-Id: Ic299a57aa5e69063c6f8d0f39c92772503b15f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872591
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#886600}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2872591 branch 4 times, most recently from 811b7d6 to ac00104 May 5, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2872591 branch 5 times, most recently from 472694c to 380bb85 May 13, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2872591 branch 3 times, most recently from 7a4ba9e to 2157e3f May 24, 2021
layout

This CL addresses a failure where an absolutely positioned item changed
its position dynamically. Previously, a new |containing_block_rect| was
not being added nor re-computed in |SimplifiedLayoutAlgorithm| for
out of flow items that are children of the grid, thus their position was
incorrect. This change computes the new containing block by calling
existing helpers in |NGGridLayoutAlgorithm|. As a result, some methods
had to be changed and constructors overloaded in order to use what was
already computed and stored in |NGGridData|.

Bug: 1045599
Change-Id: Ic299a57aa5e69063c6f8d0f39c92772503b15f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2872591
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#886600}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2872591 branch from 2157e3f to 4a65cb1 May 26, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit d838b9e into master May 26, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210526.13 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2872591 branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants