Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReplacedNG] Fix relayout boundary logic. #28853

Merged
merged 1 commit into from May 6, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

We had an issue when a replaced object was a relayout root.

With this change it was possible for a replaced element to clear its
layout results when being laid out as a layout root.

When a RecalcLayoutOverflow was triggered, we'd try and perform the
CloneWithPostLayoutFragments however this would now fail, as the
replaced element fragment "PostLayout()" call would fail, as there was
no updated fragment.

This change makes the replaced element go down the NGBlockNode::Layout
path when laying out from a relayout boundary.

Bug: 1205852, 1205977, 1205971
Change-Id: I7f195817daddd17659564e56f7e0f3b46ec53991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875638
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879920}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2875638 branch from 600439d to e996f33 May 6, 2021
We had an issue when a replaced object was a relayout root.

With this change it was possible for a replaced element to clear its
layout results when being laid out as a layout root.

When a RecalcLayoutOverflow was triggered, we'd try and perform the
CloneWithPostLayoutFragments however this would now fail, as the
replaced element fragment "PostLayout()" call would fail, as there was
no updated fragment.

This change makes the replaced element go down the NGBlockNode::Layout
path when laying out from a relayout boundary.

Bug: 1205852, 1205977, 1205971
Change-Id: I7f195817daddd17659564e56f7e0f3b46ec53991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2875638
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879920}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2875638 branch from e996f33 to e957548 May 6, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8b15320 into master May 6, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210506.51 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2875638 branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants