Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unblock of load event in display:none iframe #29216

Merged
merged 1 commit into from Jun 11, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 4, 2021

If we inserted an object into a display:none iframe during parsing after
we had updated the layout tree, we would not unblock the load event
because we did not unblock when the layout tree update was a no-op. This
typically happens because inserting elements into a non-rendered subtree
which is up-to-date does not require a subsequent update.

Makes the html-parser-threaded.html performance test start working
again.

Bug: 1216353
Change-Id: I3e5b0390c45b9e0411fe10fb22a686f39791a66f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940528
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891482}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2940528 branch 2 times, most recently from 6b7e5c8 to fecf09b Jun 7, 2021
If we inserted an object into a display:none iframe during parsing after
we had updated the layout tree, we would not unblock the load event
because we did not unblock when the layout tree update was a no-op. This
typically happens because inserting elements into a non-rendered subtree
which is up-to-date does not require a subsequent update.

Makes the html-parser-threaded.html performance test start working
again.

Bug: 1216353
Change-Id: I3e5b0390c45b9e0411fe10fb22a686f39791a66f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2940528
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891482}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2940528 branch from fecf09b to de1b591 Jun 11, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ad5c145 into master Jun 11, 2021
23 checks passed
23 checks passed
@azure-pipelines
Azure Pipelines Build #20210611.2 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2940528 branch Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants