Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1711479] Add the extended (two-value) font-size-adjust syntax to various WPT tests. #29253

Merged
merged 2 commits into from Jun 14, 2021

Conversation

moz-wptsync-bot
Copy link
Collaborator

@moz-wptsync-bot moz-wptsync-bot commented Jun 7, 2021

Differential Revision: https://phabricator.services.mozilla.com/D116280

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1711479
gecko-commit: 4e689776fe5d0c2450ee9f01ee6eeb6c1a608f65
gecko-reviewers: emilio

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Firefox project.

jfkthame added 2 commits Jun 14, 2021
…ests.

Differential Revision: https://phabricator.services.mozilla.com/D116280

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1711479
gecko-commit: 46b6ee998a7ffd2b5d90257262afb125b5658f70
gecko-reviewers: emilio
…talled font lookup.

The test here used a face with `src: local(Arial);`, while the reference file used `font-family: Arial, sans-serif`;
but these may not reliably result in the same behavior. The `@font-face` rule looks up a specific *face*,
and if that face is not found, the test will fall back to the browser's default font; but the reference might
get a *different* result if, for example, a fontconfig alias/substitution rule is present that maps Arial to
a different sans-serif than the browser's default.

So instead of trying to use a local font lookup to provide the metrics contrast with Ahem, this patch specifically
loads a second font resource (in both the testcase and reference) to provide consistent behavior.

Differential Revision: https://phabricator.services.mozilla.com/D116452

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1711479
gecko-commit: 43c6edbfc3dac8013830c4737c051cfc00ae5968
gecko-reviewers: emilio
@moz-wptsync-bot moz-wptsync-bot merged commit 861e227 into master Jun 14, 2021
21 checks passed
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1711479 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants