Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move WebCryptoAPI to any.js #29276

Merged
merged 9 commits into from Jun 11, 2021
Merged

Conversation

@lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jun 8, 2021

This PR is an alternative to #27714 that doesn't break the worker tests.

I split the PR into 5 commits, each changing one of the subfolders of the
WebCryptoAPI folder. Other commits are minor fixes.

I did not change any indentation to make reviewing easier.

@wpt-pr-bot
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot commented Jun 8, 2021

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@lucacasonato lucacasonato force-pushed the denoland:crypto_any_js branch 2 times, most recently from fb31abc to a968033 Jun 8, 2021
@lucacasonato lucacasonato force-pushed the denoland:crypto_any_js branch from a968033 to fbb79b7 Jun 8, 2021
promise_test(function() {
return Promise.all(all_promises)
.then(function() {done();})
.catch(function() {done();})
}, "setup");
Comment on lines +270 to +274

This comment has been minimized.

@lucacasonato

lucacasonato Jun 8, 2021
Author Member

.any.worker.js tests automatically call done(). This is used to prevent the test suite from preemptively exiting before these promises have resolved.

@Ms2ger
Ms2ger approved these changes Jun 11, 2021
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Didn't fully check everything, but since it looks like there's no changes to the overall number of test passes/failures, it's probably fine. One comment below.

@lucacasonato lucacasonato force-pushed the denoland:crypto_any_js branch from 068512f to 102f5a2 Jun 11, 2021
@lucacasonato
Copy link
Member Author

@lucacasonato lucacasonato commented Jun 11, 2021

Please hold on merging. Some of these tests look to be flaky now. https://github.com/web-platform-tests/wpt/pull/29276/checks?check_run_id=2801619886. I am concerned it is related to the top level promise_test change. Wan't to investigate this real quick.

@lucacasonato
Copy link
Member Author

@lucacasonato lucacasonato commented Jun 11, 2021

Ok investigated, and seems these tests were previously already flaky: https://crbug.com/1045472.

@Ms2ger Ms2ger merged commit 1423625 into web-platform-tests:master Jun 11, 2021
24 of 27 checks passed
24 of 27 checks passed
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@azure-pipelines
Azure Pipelines Build #20210611.15 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
infrastructure/ tests Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
resources/ tests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
resources/ tests (Python 3.9) Community-TC (pull_request)
Details
@community-tc-integration
tools/ integration tests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
tools/ integration tests (Python 3.9) Community-TC (pull_request)
Details
@community-tc-integration
tools/ unittests (Python 3.6) Community-TC (pull_request)
Details
@community-tc-integration
tools/ unittests (Python 3.9) Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@lucacasonato lucacasonato deleted the denoland:crypto_any_js branch Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants