Add codec specific tests for AudioDecoder. Add mulaw/alaw support. #29296
Conversation
wpt-pr-bot
approved these changes
Jun 9, 2021
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2946625
branch
4 times, most recently
from
b245ec6
to
8e91eef
This expands our AudioDecoder test coverage as was done for the VideoDecoder. Namely we now have a audioDecoder-codec-specific.js file which is parameterized based on each supported codec. This adds testing for AAC (ADTS), AAC (MP4), MP3, MULAW, and ALAW. Vorbis and FLAC will be added in a followup. R=sandersd Fixed: 1203825 Change-Id: I8130ee0d607e2f6968471ee671650b70d1269980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2946625 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#892384}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2946625
branch
from
8e91eef
to
c07d46e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This expands our AudioDecoder test coverage as was done for the
VideoDecoder. Namely we now have a audioDecoder-codec-specific.js
file which is parameterized based on each supported codec.
This adds testing for AAC (ADTS), AAC (MP4), MP3, MULAW, and
ALAW. Vorbis and FLAC will be added in a followup.
R=sandersd
Fixed: 1203825
Change-Id: I8130ee0d607e2f6968471ee671650b70d1269980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2946625
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892384}
The text was updated successfully, but these errors were encountered: