Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codec specific tests for AudioDecoder. Add mulaw/alaw support. #29296

Merged
merged 1 commit into from Jun 15, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 9, 2021

This expands our AudioDecoder test coverage as was done for the
VideoDecoder. Namely we now have a audioDecoder-codec-specific.js
file which is parameterized based on each supported codec.

This adds testing for AAC (ADTS), AAC (MP4), MP3, MULAW, and
ALAW. Vorbis and FLAC will be added in a followup.

R=sandersd

Fixed: 1203825
Change-Id: I8130ee0d607e2f6968471ee671650b70d1269980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2946625
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892384}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2946625 branch 4 times, most recently from b245ec6 to 8e91eef Jun 15, 2021
This expands our AudioDecoder test coverage as was done for the
VideoDecoder. Namely we now have a audioDecoder-codec-specific.js
file which is parameterized based on each supported codec.

This adds testing for AAC (ADTS), AAC (MP4), MP3, MULAW, and
ALAW. Vorbis and FLAC will be added in a followup.

R=sandersd

Fixed: 1203825
Change-Id: I8130ee0d607e2f6968471ee671650b70d1269980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2946625
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892384}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2946625 branch from 8e91eef to c07d46e Jun 15, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5d07d9b into master Jun 15, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2946625 branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants