Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLPattern: Support username:password@ in constructor strings. #29311

Merged
merged 1 commit into from Jun 14, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 9, 2021

This adds support to for specifying a username and password pattern in
the constructor string. While this is unlikely to be used frequently
it was added to complete support for all URL components.

This CL also adds a class comment for the Parser which was forgotten
in previous CLs.

Bug: 1141510
Change-Id: I984db6224b1fd36390a21c241d204573ed50d78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2937293
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892269}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This adds support to for specifying a username and password pattern in
the constructor string.  While this is unlikely to be used frequently
it was added to complete support for all URL components.

This CL also adds a class comment for the `Parser` which was forgotten
in previous CLs.

Bug: 1141510
Change-Id: I984db6224b1fd36390a21c241d204573ed50d78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2937293
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892269}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit fea1c2d into master Jun 14, 2021
18 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2937293 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants