Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport propagation of forced-color-adjust #29321

Merged
merged 1 commit into from Jun 11, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 9, 2021

Forced-color-adjust propagates from the root to the viewport but not
from the body, per the resolution in the following spec issue:
w3c/csswg-drafts#6307

This CL also moves the call for Document::UpdateForcedColors() earlier
in Document::Initialize() to ensure the state of forced colors mode
is set early enough when determining the background-color of the
viewport in forced colors mode.

Bug: 1212201
Change-Id: Ib8109659083d21e1c29fc8bdae519393cb417688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2915382
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#891653}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2915382 branch from 4eb2dd0 to 56c6da4 Jun 10, 2021
Forced-color-adjust propagates from the root to the viewport but not
from the body, per the resolution in the following spec issue:
w3c/csswg-drafts#6307

This CL also moves the call for Document::UpdateForcedColors() earlier
in Document::Initialize() to ensure the state of forced colors mode
is set early enough when determining the background-color of the
viewport in forced colors mode.

Bug: 1212201
Change-Id: Ib8109659083d21e1c29fc8bdae519393cb417688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2915382
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#891653}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2915382 branch from 56c6da4 to 6d8e6db Jun 11, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2577ffb into master Jun 11, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210611.42 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2915382 branch Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants