Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceTiming]: Cleanup cors-preflight.any.js #29333

Merged
merged 1 commit into from Jun 11, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 10, 2021

This CL updates the cors-preflight.any.js test to conform to the new
style/guidelines.

In particular, some helpers have been renamed for clarity and we use a
PerformanceObserver instead of calling performance.getEntriesByName().

Bug: 1171767
Change-Id: Ic6a0116e099a77a808bd9dc748f4a573ae349ad2
GitHubIssue: w3c/resource-timing#254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951092
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891648}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This CL updates the cors-preflight.any.js test to conform to the new
style/guidelines.

In particular, some helpers have been renamed for clarity and we use a
PerformanceObserver instead of calling performance.getEntriesByName().

Bug: 1171767
Change-Id: Ic6a0116e099a77a808bd9dc748f4a573ae349ad2
GitHubIssue: w3c/resource-timing#254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951092
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891648}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2951092 branch from 1339d7d to aac4b78 Jun 11, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 436a69d into master Jun 11, 2021
22 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2951092 branch Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants