Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXR: fix regression in obtaining pose between targetRay and grip space #29336

Merged
merged 1 commit into from Jun 14, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 10, 2021

Introduces a change to native origins to be able to distinguish between
input-source-derived grip space origin and target ray space origin.
Since the native origins of those 2 spaces were identical, the change
introduced in https://crrev.com/c/2803481 caused them to be treated as
the same space, thus resulting in returning identity pose from
XRFrame::getPose() method.

Also adds a WPT test that would've caught this regression.

Other minor changes:

  • converted if-elseif-else chain into a switch statement

Fixed: 1214497
Change-Id: I66e18b863b2769fce6c8126b5d0ddade99fe9b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953960
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892183}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Introduces a change to native origins to be able to distinguish between
input-source-derived grip space origin and target ray space origin.
Since the native origins of those 2 spaces were identical, the change
introduced in https://crrev.com/c/2803481 caused them to be treated as
the same space, thus resulting in returning identity pose from
XRFrame::getPose() method.

Also adds a WPT test that would've caught this regression.

Other minor changes:
- converted if-elseif-else chain into a switch statement

Fixed: 1214497
Change-Id: I66e18b863b2769fce6c8126b5d0ddade99fe9b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953960
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892183}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bc614ca into master Jun 14, 2021
27 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2953960 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants