Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change |RebuildFragmentTreeSpine| to check |PhysicalFragmentCount| #29337

Merged
merged 1 commit into from Jun 11, 2021

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 11, 2021

This patch changes |RebuildFragmentTreeSpine| to check
|PhysicalFragmentCount| instead of |CanUseNewLayout|.

This is consistent with the change for the subtree layout in
r890653 crrev.com/c/2934743, and can handle flow threads
correctly, because flow threads are not |LayoutNGMixin| even
when NG block fragmentation is enabled.

Bug: 965639, 829028
Change-Id: I8c9cdb16e37e67b7a0a9b0665e633d8eb200395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952733
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891728}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This patch changes |RebuildFragmentTreeSpine| to check
|PhysicalFragmentCount| instead of |CanUseNewLayout|.

This is consistent with the change for the subtree layout in
r890653 crrev.com/c/2934743, and can handle flow threads
correctly, because flow threads are not |LayoutNGMixin| even
when NG block fragmentation is enabled.

Bug: 965639, 829028
Change-Id: I8c9cdb16e37e67b7a0a9b0665e633d8eb200395d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2952733
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891728}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2952733 branch from 0a29c28 to 73f11ca Jun 11, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e4979f6 into master Jun 11, 2021
22 checks passed
22 checks passed
@azure-pipelines
Azure Pipelines Build #20210611.44 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@staging-wpt-fyi
staging.wpt.fyi - chrome[experimental] Chrome results
Details
@staging-wpt-fyi
staging.wpt.fyi - firefox[experimental] Firefox results
Details
@staging-wpt-fyi
staging.wpt.fyi - safari[experimental] Safari results
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2952733 branch Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants