Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test for summary element as list item #29341

Merged
merged 2 commits into from Jun 14, 2021

Conversation

@svillar
Copy link
Contributor

@svillar svillar commented Jun 11, 2021

The patch that fixed summary-display-list-item.html in WebKit was not completely correct and caused some regressions when the children of the summary where flex boxes.

Adding a new test to verify that we don't regress on that.

@svillar
Copy link
Contributor Author

@svillar svillar commented Jun 11, 2021

I'm also BTW renaming the original summary-display-list-item.html to summary-display-list-item-001.html

@foolip
foolip approved these changes Jun 12, 2021
<title>CSS Test: summary with 'display: list-item' and flex children</title>
<link rel="author" title="Cameron McCormack" href="mailto:">
<link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com">
<link rel="match" href="summary-display-list-item-002-ref.html">

This comment has been minimized.

@foolip

foolip Jun 12, 2021
Member

The lint is failing because of this.

This comment has been minimized.

@svillar

svillar Jun 14, 2021
Author Contributor

Copy&paste classical

<link rel="author" title="Cameron McCormack" href="mailto:">
<link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com">
<link rel="match" href="summary-display-list-item-002-ref.html">
<link rel="help" href="https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements">

This comment has been minimized.

@foolip

foolip Jun 12, 2021
Member

I'd drop this and only link the spec in the test.

This comment has been minimized.

@svillar

svillar Jun 14, 2021
Author Contributor

done

@svillar svillar merged commit a8e5772 into web-platform-tests:master Jun 14, 2021
20 checks passed
20 checks passed
@azure-pipelines
Azure Pipelines Build #20210614.34 succeeded
Details
@azure-pipelines
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
@azure-pipelines
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
@community-tc-integration
download-firefox-nightly Community-TC (pull_request)
Details
@community-tc-integration
lint Community-TC (pull_request)
Details
@community-tc-integration
sink-task Community-TC (pull_request)
Details
@community-tc-integration
update-built Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-chrome-dev-stability Community-TC (pull_request)
Details
@community-tc-integration
wpt-decision-task Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-results-without-changes Community-TC (pull_request)
Details
@community-tc-integration
wpt-firefox-nightly-stability Community-TC (pull_request)
Details
@wpt-fyi
wpt.fyi - chrome[experimental] Chrome results
Details
@wpt-fyi
wpt.fyi - firefox[experimental] Firefox results
Details
@wpt-fyi
wpt.fyi - safari[experimental] Safari results
Details
@svillar svillar deleted the svillar:summary-display branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants