Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test for summary element as list item #29341

Merged
merged 2 commits into from Jun 14, 2021

Conversation

svillar
Copy link
Contributor

@svillar svillar commented Jun 11, 2021

The patch that fixed summary-display-list-item.html in WebKit was not completely correct and caused some regressions when the children of the summary where flex boxes.

Adding a new test to verify that we don't regress on that.

@svillar
Copy link
Contributor Author

@svillar svillar commented Jun 11, 2021

I'm also BTW renaming the original summary-display-list-item.html to summary-display-list-item-001.html

foolip
foolip approved these changes Jun 12, 2021
<title>CSS Test: summary with 'display: list-item' and flex children</title>
<link rel="author" title="Cameron McCormack" href="mailto:">
<link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com">
<link rel="match" href="summary-display-list-item-002-ref.html">
Copy link
Member

@foolip foolip Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint is failing because of this.

Copy link
Contributor Author

@svillar svillar Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy&paste classical

<link rel="author" title="Cameron McCormack" href="mailto:">
<link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com">
<link rel="match" href="summary-display-list-item-002-ref.html">
<link rel="help" href="https://html.spec.whatwg.org/multipage/rendering.html#the-details-and-summary-elements">
Copy link
Member

@foolip foolip Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop this and only link the spec in the test.

Copy link
Contributor Author

@svillar svillar Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@svillar svillar merged commit a8e5772 into web-platform-tests:master Jun 14, 2021
20 checks passed
@svillar svillar deleted the summary-display branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants