Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_approx_equals in css/css-text/i18n #29346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@laurynmm
Copy link
Contributor

@laurynmm laurynmm commented Jun 11, 2021

Fixes #25084.

@laurynmm
Copy link
Contributor Author

@laurynmm laurynmm commented Jun 25, 2021

Hey @frivoal and @xfq - @r12a mentioned that you two might be better suited to review this pull request that updated some internationalization tests of his that had been ported to wpt and changed from his original versions already. I'm new to wpt and just getting my feet wet with contributing here, so any feedback would be great. Thanks!

@laurynmm laurynmm force-pushed the laurynmm:cleanup-css-text-i18n-assertions branch from 0d46a38 to 5bb30aa Sep 15, 2021
@laurynmm
Copy link
Contributor Author

@laurynmm laurynmm commented Sep 15, 2021

Hey @kojiishi - I've had this pull request for a clean-up issue on some i18n tests pending for a few months. I saw that you had reviewed a change to some of these files at the end of July and was wondering if you could take a look at mine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants