Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DCHECK() about signs of w test the same condition the caller does. #29349

Merged
merged 1 commit into from Jun 14, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 11, 2021

This changes the DCHECK() that tests that the signs of h1.w() and h2.w()
are different to test exactly the same condition that the callers test.
While it looks equivalent, it's different in the cases where the values
are not finite, which fuzzers have (unfortunately) managed to hit, and
which we should probably eventually address in a better way (given that
it's undefined behavior in C++).

Fixed: 1217813
Change-Id: I5b268dad8a2c2435789b00620ca0bd3cdd7bb919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956400
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892200}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

This changes the DCHECK() that tests that the signs of h1.w() and h2.w()
are different to test exactly the same condition that the callers test.
While it looks equivalent, it's different in the cases where the values
are not finite, which fuzzers have (unfortunately) managed to hit, and
which we should probably eventually address in a better way (given that
it's undefined behavior in C++).

Fixed: 1217813
Change-Id: I5b268dad8a2c2435789b00620ca0bd3cdd7bb919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956400
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892200}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ca6913e into master Jun 14, 2021
25 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2956400 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants