Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BreakoutBox] Replace MSTP::is_pending_pull_ with a counter" #29351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 11, 2021

This reverts commit 7a1512f2784fe0b3c68aa7a45b89aea6b38bf025.

Reason for revert: crbug.com/1219040

Original change's description:

[BreakoutBox] Replace MSTP::is_pending_pull_ with a counter

|is_pending_pull_| was used to make sure that frames were made available
to the stream only if there was a pending pull request.

However, if multiple pull requests are issued and then no more pull
requests arrive, some of the corresponding read requests will remain
unsettled when |is_pending_pull_| becomes false.

This CL fixes this by replacing the boolean |is_pending_pull_| with a
counter.

Bug: 1218120
Change-Id: I0ffc038a73a6cd1d387dc17e9c21f2c62fc50613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2950171
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891735}

Bug: 1218120
Change-Id: Ieabc569525b9da16cfd16234ed93ac7169769942
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/2957106
WPT-Export-Revision: 0a30fe38c6f64e1933f7512be601f76ced05a525

This reverts commit 7a1512f2784fe0b3c68aa7a45b89aea6b38bf025.

Reason for revert: crbug.com/1219040

Original change's description:
> [BreakoutBox] Replace MSTP::is_pending_pull_ with a counter
>
> |is_pending_pull_| was used to make sure that frames were made available
> to the stream only if there was a pending pull request.
>
> However, if multiple pull requests are issued and then no more pull
> requests arrive, some of the corresponding read requests will remain
> unsettled when |is_pending_pull_| becomes false.
>
> This CL fixes this by replacing the boolean |is_pending_pull_| with a
> counter.
>
> Bug: 1218120
> Change-Id: I0ffc038a73a6cd1d387dc17e9c21f2c62fc50613
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2950171
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#891735}

Bug: 1218120
Change-Id: Ieabc569525b9da16cfd16234ed93ac7169769942
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants